Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change devcontainer make up command to run after start #2146

Merged
merged 2 commits into from
May 15, 2024

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented May 12, 2024

Proposed Changes

  • Runs make up post start rather than post attach

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@skks1212 skks1212 requested a review from a team as a code owner May 12, 2024 17:30
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.28%. Comparing base (51ce81e) to head (ec50e09).
Report is 75 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2146      +/-   ##
===========================================
+ Coverage    62.20%   63.28%   +1.08%     
===========================================
  Files          221      226       +5     
  Lines        12204    12494     +290     
  Branches      1742     1781      +39     
===========================================
+ Hits          7591     7907     +316     
+ Misses        4305     4252      -53     
- Partials       308      335      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari merged commit 50b2a12 into develop May 15, 2024
4 of 5 checks passed
@vigneshhari vigneshhari deleted the devcontainer-makeup branch May 15, 2024 06:58
vigneshhari added a commit that referenced this pull request May 15, 2024
* Update max_length for phone numbers to adhere to ITU-T E.164 standard (#2138)

* Update max_length for phone numbers to adhere to ITU-T E.164 standard

* Clean up an empty line

* Adds missing migrations

---------

Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Adds support for doctors and nurses discussions threads in Discussion Notes (#2137)

* Adds support for doctors and nurses discussions threads in Discussion Notes

* switch to using small integer field

* updated and fixes based on test cases

* rebase migrations

* Remake migrations

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Allow `audio/mp4` by default (#2094)

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Bump Dependencies (#2143)

* Vigneshhari/bump dependencies (#2145)

* Bump Dependencies

* Bump Dependencies

* Bump Dependencies

* Bump Dependencies

* Skip creating event group if all fields are null (#2134)

* ABDM M3 (#1829)

Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: Gigin George <mail.gigin@gmail.com>

* Increase area of specialisation in doctors (#2102)

* update doctor types

* Add Migration

---------

Co-authored-by: Rithvik Nishad <rithvik.nishad@egovernments.org>
Co-authored-by: Gigin George <mail.gigin@gmail.com>

* Added discharge patient filters (#2124)

* added discharge patient filters

* updated filters

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* converted investigation and investigation group data into JSON (#1912)

* converted investigation and investigation group data into JSON

* created json files for investigations and investigation_groups

* updated investigations.json

* fixed json data,command and migrations

* fixing migrations

* fixing lint issue

* update migrations

* update migrations

---------

Co-authored-by: Aakash Singh <mail@singhaakash.dev>

* Drops support for cloning previous log update (#2127)

* Drop support for cloning previous log update

* undo unrelated changes

---------

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Change devcontainer make up command to run after start (#2146)

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Removes unused `current_health` field from Daily Rounds (#2162)

Removes unused `current_health` from Daily Rounds

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* Display users list based on user access limitation (#1742)

* Refactor get_queryset method in UserViewSet

* Used get_accessible_facilities instead of subquery
to fetch the facilities linked to the user

* fixed failing tests

* fix queryset

---------

Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: khavinshankar <khavinshankar@gmail.com>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>

* adds missing merge migrations (#2169)

merge migrations

---------

Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>
Co-authored-by: Rithvik Nishad <rithvik.nishad@egovernments.org>
Co-authored-by: Aakash Singh <mail@singhaakash.dev>
Co-authored-by: Khavin Shankar <khavinshankar@gmail.com>
Co-authored-by: Gigin George <mail.gigin@gmail.com>
Co-authored-by: Rashmik <146672184+rash-27@users.noreply.github.com>
Co-authored-by: Shivank Kacker <kacker.shivank@gmail.com>
Co-authored-by: Prafful Sharma <115104695+DraKen0009@users.noreply.github.com>
Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev container runs make up every time you connect to it
5 participants