Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply feature for Doctor notes #2160

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

UdaySagar-Git
Copy link

Associated Issue

Frontend PR: coronasafe/care_fe#7805

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@nihal467
Copy link
Member

@UdaySagar-Git fix the lint and test in the PR

@UdaySagar-Git
Copy link
Author

@nihal467 fixed !

care/facility/api/serializers/patient.py Outdated Show resolved Hide resolved
@sainak
Copy link
Member

sainak commented May 14, 2024

@UdaySagar-Git how will you ensure that the notes that you fetch that are replies include the parent in response?, also what if the notes have replies, but it were not fetched in the current response

cc @rithviknishad

@UdaySagar-Git
Copy link
Author

UdaySagar-Git commented May 15, 2024

@sainak , thanks for pointing that out. It won't fetch the parent if there are more notes. Instead of sending just the ID, sending the complete parent object along with the note would solve this. Should I consider that and make changes in frontend according to it?

@rithviknishad
Copy link
Member

@UdaySagar-Git we could add a ReplyToPatientNoteSerializer containing a lesser number of fields, just the required ones.

@UdaySagar-Git UdaySagar-Git requested a review from sainak May 15, 2024 15:26
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, LGTM.

Tests would be appreciated 😄

care/facility/api/serializers/patient.py Outdated Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed

@UdaySagar-Git
Copy link
Author

@rithviknishad forgot to commit 😅 ,
just added

@UdaySagar-Git UdaySagar-Git requested a review from sainak May 21, 2024 09:32
@nihal467
Copy link
Member

LGTM

@nihal467
Copy link
Member

@UdaySagar-Git can you make the changes requested

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2024

@UdaySagar-Git what is the update on the PR

@UdaySagar-Git
Copy link
Author

@nihal467 this pr is ready for a final review

@UdaySagar-Git
Copy link
Author

UdaySagar-Git commented Jul 3, 2024

@vigneshhari can you please review this , added a extra validation check for consultation
since the doctor notes will be specfic to consultation and is required

@UdaySagar-Git
Copy link
Author

@nihal467 can you try re-running the tests now ?

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.50%. Comparing base (1912662) to head (386102f).

Files Patch % Lines
care/facility/api/serializers/patient.py 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2160      +/-   ##
===========================================
+ Coverage    63.48%   63.50%   +0.01%     
===========================================
  Files          238      238              
  Lines        13264    13281      +17     
  Branches      1886     1890       +4     
===========================================
+ Hits          8421     8434      +13     
- Misses        4490     4492       +2     
- Partials       353      355       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari
Copy link
Member

@sainak re-review required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants