Convert ABDM into Plug - Part 1/2 #2161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainak
reviewed
May 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2161 +/- ##
===========================================
+ Coverage 63.48% 63.57% +0.08%
===========================================
Files 238 237 -1
Lines 13264 13248 -16
Branches 1886 1889 +3
===========================================
+ Hits 8421 8422 +1
+ Misses 4490 4474 -16
+ Partials 353 352 -1 ☔ View full report in Codecov by Sentry. |
rithviknishad
approved these changes
May 20, 2024
sainak
approved these changes
May 20, 2024
|
@vigneshhari conditionally approving it for review alone by @sainak @rithviknishad & @vigneshhari, since ABDM fetched patient record takes some time to reflect in the platform (pending test) |
sainak
requested changes
Jul 3, 2024
rithviknishad
approved these changes
Jul 3, 2024
sainak
approved these changes
Jul 4, 2024
|
LGTM |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request represents the first phase of converting the ABDM system into a plug. The primary focus of this PR is to refactor the relationship between the ABHA number and the patient model, alongside improvements to signal handling and routing. Detailed changes include:
Model Relationship Reversal: Changed the relationship dynamics by moving the abha_number field from the patient model to the abha_number model. This involves making patient a field within the abha_number model to better align with our new architecture.
Signal Creation for Care Context: Implemented a new signal that triggers the creation of a care context whenever a consultation is saved. This enhances the functionality and integration of care context within our system.
ABHA Number API Enhancements: Introduced a new abha_number viewset, serializer, and routes. These additions are designed to streamline the handling and accessibility of ABHA numbers within our system.
This PR lays the groundwork for the subsequent phase, which will further integrate and optimize the ABDM plug system.