Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration to change meta.camera_address to meta.local_ip_address #771

Merged
merged 2 commits into from
May 22, 2022

Conversation

iamsdas
Copy link
Contributor

@iamsdas iamsdas commented May 20, 2022

Add data migration to change meta.camera_address to meta.local_ip_address in Asset table.

fixes: #759

@iamsdas iamsdas requested a review from a team as a code owner May 20, 2022 14:36
Co-authored-by: Aakash Singh <46787056+sainAk@users.noreply.github.com>
Copy link
Member

@vigneshhari vigneshhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. No Manual Check Done.

@vigneshhari vigneshhari merged commit 0a93716 into ohcnetwork:master May 22, 2022
@iamsdas iamsdas deleted the migration branch May 22, 2022 10:53
def update_json_field_names(apps, schema_editor):
Asset = apps.get_model('facility', 'Asset')

with transaction.atomic:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIgrations are atomic by default, you are missing () as well.

@iamsdas iamsdas restored the migration branch May 24, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend: Migration to change meta.camera_address to meta.local_ip_address
3 participants