Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY Permissions added for assetLocation viewset #830

Merged
merged 4 commits into from
Jun 13, 2022
Merged

DRY Permissions added for assetLocation viewset #830

merged 4 commits into from
Jun 13, 2022

Conversation

ishanExtreme
Copy link
Contributor

Issue Fixed

fixes #818

Updates

Read only users can now only read the location list and will not be able to perform any create/edit on it

  • Added new DRY permission class models/mixins/permissions/asset.py
  • Updated AssetLocation model to inherit from DRYPermission class
  • Updated AssetLocationViewset to use DryPermission and isAuthenticated Permission

@ishanExtreme ishanExtreme requested a review from a team as a code owner June 7, 2022 10:34
@ishanExtreme ishanExtreme requested a review from sainak June 7, 2022 10:35
sainak
sainak approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@sainak sainak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not change the formatting of code, It generates diff noise which makes review harder, otherwise LGTM

@vigneshhari vigneshhari merged commit f670ea9 into coronasafe:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@sainak sainak sainak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: read-only user can edit/update location management of a facility
3 participants
@ishanExtreme @vigneshhari @sainak