Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test warnings and parallel runs #851

Merged
merged 6 commits into from
Jun 11, 2022

Conversation

sainak
Copy link
Member

@sainak sainak commented Jun 11, 2022

we are going to drop most of the templates so django-coverage-plugin wont be required

@sainak sainak requested a review from a team as a code owner June 11, 2022 08:13
@codecov-commenter
Copy link

Codecov Report

Merging #851 (20d96c5) into feat/testing (30b760d) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           feat/testing     #851      +/-   ##
================================================
- Coverage         53.44%   53.24%   -0.21%     
================================================
  Files               177      153      -24     
  Lines              8700     8008     -692     
  Branches              0     1404    +1404     
================================================
- Hits               4650     4264     -386     
+ Misses             4050     3711     -339     
- Partials              0       33      +33     
Impacted Files Coverage Δ
care/utils/filters/choicefilter.py 75.00% <0.00%> (-6.25%) ⬇️
...e/utils/serializer/phonenumber_ispossible_field.py 87.50% <0.00%> (-6.25%) ⬇️
care/users/api/serializers/user.py 61.86% <0.00%> (-4.24%) ⬇️
care/facility/models/facility.py 85.53% <0.00%> (-3.78%) ⬇️
care/users/models.py 85.61% <0.00%> (-3.60%) ⬇️
care/audit_log/receivers.py 26.26% <0.00%> (-3.04%) ⬇️
care/utils/models/jsonfield.py 23.07% <0.00%> (-2.57%) ⬇️
care/facility/models/patient.py 92.85% <0.00%> (-1.99%) ⬇️
care/facility/models/shifting.py 76.78% <0.00%> (-1.79%) ⬇️
care/facility/models/resources.py 76.78% <0.00%> (-1.79%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b760d...20d96c5. Read the comment docs.

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@shivankacker shivankacker merged commit d289ab9 into feat/testing Jun 11, 2022
@sainak sainak deleted the sainAk/fix/test-warnings branch June 11, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants