Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed current health field #882

Closed
wants to merge 7 commits into from
Closed

Removed current health field #882

wants to merge 7 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Jun 23, 2022 •
edited by sainak
Loading

Updates

#880

  • Removed current health from API, migration, model

@aeswibon aeswibon requested a review from a team as a code owner June 23, 2022 17:46
sainak
sainak requested changes Jun 23, 2022
View reviewed changes
Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create new migrations instead of editing previous ones.

@aeswibon
Copy link
Member Author

@sainak Okay I will make new migration

@aeswibon
Copy link
Member Author

@sainak I have added new migrations

@aeswibon
Copy link
Member Author

Also this field is also present in the template. So do I have to delete from template too?

@sainak
Copy link
Member

sainak commented Jun 24, 2022

Also this field is also present in the template. So do I have to delete from template too?

we are not using template views anymore and it is planned to be removed so its fine to leave it as it is.

@aeswibon
Copy link
Member Author

Also this field is also present in the template. So do I have to delete from template too?

we are not using template views anymore and it is planned to be removed so its fine to leave it as it is.

Okay

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #882 (c4b474f) into master (6539551) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
- Coverage   52.56%   52.55%   -0.02%     
==========================================
  Files         182      182              
  Lines        8990     8987       -3     
==========================================
- Hits         4726     4723       -3     
  Misses       4264     4264
Impacted Files Coverage Δ
care/facility/models/patient_base.py 100.00% <ø> (ø)
care/facility/api/serializers/daily_round.py 36.56% <100.00%> (-0.47%) ⬇️
care/facility/models/daily_round.py 88.35% <100.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

@sainak sainak sainak approved these changes

Assignees
No one assigned
Labels
ops-review-pending reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aeswibon @sainak @codecov-commenter @vigneshhari