Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated message when token is not valid #906

Merged
merged 4 commits into from
Jul 3, 2022

Conversation

Marmik2003
Copy link
Contributor

@Marmik2003 Marmik2003 requested a review from a team as a code owner July 2, 2022 09:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #906 (ca6c768) into master (179d23e) will decrease coverage by 1.21%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
- Coverage   53.92%   52.70%   -1.22%     
==========================================
  Files         179      179              
  Lines        8742     8748       +6     
==========================================
- Hits         4714     4611     -103     
- Misses       4028     4137     +109     
Impacted Files Coverage Δ
config/authentication.py 31.42% <20.00%> (-0.88%) ⬇️
...e/utils/serializer/phonenumber_ispossible_field.py 50.00% <0.00%> (-43.75%) ⬇️
config/serializers.py 36.84% <0.00%> (-31.58%) ⬇️
care/audit_log/middleware.py 47.36% <0.00%> (-22.81%) ⬇️
care/users/models.py 73.75% <0.00%> (-15.61%) ⬇️
care/users/api/viewsets/users.py 43.50% <0.00%> (-12.34%) ⬇️
care/users/api/serializers/user.py 56.77% <0.00%> (-9.33%) ⬇️
care/facility/models/patient.py 88.09% <0.00%> (-6.75%) ⬇️
care/facility/models/facility.py 84.90% <0.00%> (-4.41%) ⬇️
care/audit_log/receivers.py 27.27% <0.00%> (-2.03%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179d23e...ca6c768. Read the comment docs.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This auth class is used for middlewares its not used by the front-end, to change the message you need to override get_validated_token in CustomJWTAuthentication where you need to catch InvalidToken and re raise it with a different messege.

Copy link
Member

@sainak sainak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config/authentication.py Outdated Show resolved Hide resolved
@sainak sainak self-requested a review July 3, 2022 05:40
@vigneshhari vigneshhari merged commit a271e2c into coronasafe:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Timeout Pop-up Correction
4 participants