Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release July Week 4 #945

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Production Release July Week 4 #945

merged 3 commits into from
Jul 24, 2022

Conversation

mathew-alex
Copy link
Contributor

No description provided.

sainak and others added 3 commits July 18, 2022 20:44
* fix middleware authentication

* add some docs

* improve error messages

* get patient_from_asset it inly if patient is active
* Fixed facility creation permission

* Made requested changes

* Refactored the code

* Optimised facility permissions check

Co-authored-by: Vignesh Hari <vichuhari100@gmail.com>
@mathew-alex mathew-alex requested a review from a team as a code owner July 24, 2022 14:37
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #945 (964a7d6) into production (9730efd) will increase coverage by 0.01%.
The diff coverage is 55.10%.

@@              Coverage Diff               @@
##           production     #945      +/-   ##
==============================================
+ Coverage       54.23%   54.24%   +0.01%     
==============================================
  Files             181      181              
  Lines            8826     8850      +24     
==============================================
+ Hits             4787     4801      +14     
- Misses           4039     4049      +10     
Impacted Files Coverage Δ
care/facility/summarisation/facility_capacity.py 42.10% <0.00%> (-0.45%) ⬇️
config/authentication.py 35.44% <28.00%> (+2.58%) ⬆️
care/facility/api/viewsets/mixins/access.py 25.58% <66.66%> (+3.08%) ⬆️
...are/facility/models/mixins/permissions/facility.py 50.00% <80.00%> (+8.33%) ⬆️
care/facility/api/viewsets/patient_consultation.py 63.26% <100.00%> (+0.76%) ⬆️
care/facility/models/patient_consultation.py 96.55% <100.00%> (ø)
care/facility/models/mixins/permissions/base.py 50.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9730efd...964a7d6. Read the comment docs.

@mathew-alex mathew-alex merged commit 0b08472 into production Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants