Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (icd): added scraper for icd #947

Merged
merged 9 commits into from
Aug 25, 2022
Merged

feat (icd): added scraper for icd #947

merged 9 commits into from
Aug 25, 2022

Conversation

khavinshankar
Copy link
Member

No description provided.

@khavinshankar khavinshankar requested a review from a team as a code owner July 25, 2022 14:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #947 (a1144e1) into master (6bd66bf) will decrease coverage by 1.29%.
The diff coverage is 50.66%.

❗ Current head a1144e1 differs from pull request most recent head 3d04d91. Consider uploading reports for the commit 3d04d91 to get more accurate results

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
- Coverage   54.02%   52.72%   -1.30%     
==========================================
  Files         182      184       +2     
  Lines        8990     8889     -101     
==========================================
- Hits         4857     4687     -170     
- Misses       4133     4202      +69     
Impacted Files Coverage Δ
care/facility/api/viewsets/patient.py 47.90% <0.00%> (-0.34%) ⬇️
...re/facility/management/commands/scrape_icd_data.py 0.00% <0.00%> (ø)
care/facility/models/file_upload.py 68.88% <0.00%> (ø)
care/facility/models/icd.py 0.00% <0.00%> (ø)
care/facility/models/json_schema/asset.py 100.00% <ø> (ø)
care/facility/models/patient.py 88.09% <ø> (-6.75%) ⬇️
care/facility/static_data/icd11.py 0.00% <0.00%> (ø)
care/users/api/viewsets/users.py 42.94% <0.00%> (-12.90%) ⬇️
care/utils/assetintegration/onvif.py 38.23% <ø> (+1.09%) ⬆️
care/facility/api/viewsets/file_upload.py 48.57% <15.38%> (-2.95%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vigneshhari
Copy link
Member

vigneshhari commented Jul 25, 2022

Add descriptions in all PRs!
Explain the need for this feature, how its implemented and what might be affected with its addition.

@khavinshankar
Copy link
Member Author

This pr adds features to use the classification of diseases from ICD11 (https://icd.who.int/) Refer: ohcnetwork/care_fe#2016

context: Initially, for the same thing proxying was suggested (care fe -> be -> icd.who.int) [#864] but Bodhi suggested to store the diseases directly in care db because of the reliability issues

4 endpoints are added:
image

GET /icd: for searching the diseases using label
GET /icd/{id}: for get a specific disease by id
POST /icd: for adding new disease or diseases (if needed)
GET /icd/scrape (only can be accessed by admin user): for triggering celery task for scraping icd website and adding those diseases to db

@vigneshhari
Copy link
Member

OpenAPI documentation would be nice for this endpoint

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg gigincg merged commit 362f794 into master Aug 25, 2022
@sainak sainak deleted the icd11 branch September 6, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants