Fixes: Permission Error during Facility Delete #976

aeswibon · 2022-08-10T15:23:42Z

Updates

Fixes Issue: Permission Error when user tries to delete Facility #975
Fixes Unable to delete facility with state admin privileage care_fe#3329
Added has_destroy_permission method for permission checking
Updated the logic of has_write_permission method
Formatted the code

aeswibon · 2022-08-12T14:32:23Z

I have removed LocalBodyAdmin permissions for facility deletion

care/facility/models/mixins/permissions/facility.py

codecov-commenter · 2022-09-09T05:59:15Z

Codecov Report

Merging #976 (53cc89e) into master (6bd66bf) will decrease coverage by 1.30%.
The diff coverage is 47.19%.

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
- Coverage   54.02%   52.72%   -1.31%     
==========================================
  Files         182      183       +1     
  Lines        8990     8932      -58     
==========================================
- Hits         4857     4709     -148     
- Misses       4133     4223      +90

Impacted Files	Coverage Δ
care/facility/api/viewsets/patient.py	`47.90% <0.00%> (-0.34%)`	⬇️
...re/facility/management/commands/scrape_icd_data.py	`0.00% <0.00%> (ø)`
care/facility/models/file_upload.py	`68.88% <0.00%> (ø)`
care/facility/models/json_schema/asset.py	`100.00% <ø> (ø)`
care/facility/models/patient.py	`88.09% <ø> (-6.75%)`	⬇️
care/facility/static_data/icd11.py	`0.00% <0.00%> (ø)`
care/users/api/viewsets/users.py	`42.94% <0.00%> (-12.90%)`	⬇️
care/utils/assetintegration/onvif.py	`38.23% <ø> (+1.09%)`	⬆️
config/settings/deployment.py	`0.00% <ø> (ø)`
config/settings/local.py	`0.00% <0.00%> (ø)`
... and 34 more