Fixes: Permission Error during Facility Delete

care/facility/api/viewsets/facility.py

@@ -156,7 +156,6 @@ def cover_image_delete(self, *args, **kwargs):
         facility.save()
         return Response(status=status.HTTP_204_NO_CONTENT)
 
-
 class AllFacilityViewSet(
     mixins.RetrieveModelMixin,
     mixins.ListModelMixin,

care/facility/models/mixins/permissions/facility.py

@@ -9,30 +9,44 @@ def has_bulk_upsert_permission(request):
 
     @staticmethod
     def has_write_permission(request):
-        from care.users.models import District, LocalBody, State
-
+        from care.users.models import State, District, LocalBody
+        
         try:
             state = State.objects.get(id=request.data["state"])
             district = District.objects.get(id=request.data["district"])
-            local_body = LocalBody.objects.get(id=request.data["local_body"])
             return (
                 request.user.is_superuser
                 or (
-                    request.user.user_type <= User.TYPE_VALUE_MAP["LocalBodyAdmin"]
+                    request.user.user_type > User.TYPE_VALUE_MAP["DistrictAdmin"]
                     and state == request.user.state
-                    and district == request.user.district
-                    and local_body == request.user.local_body
                 )
                 or (
                     request.user.user_type > User.TYPE_VALUE_MAP["LocalBodyAdmin"]
-                    and request.user.user_type <= User.TYPE_VALUE_MAP["DistrictAdmin"]
                     and state == request.user.state
                     and district == request.user.district
                 )
+            )
+        except Exception:
+            return False
+
+    @staticmethod
+    def has_destroy_permission(request):
+        from care.facility.models import Facility
+
+        try:
+            facility = Facility.objects.get(
+                external_id=request.parser_context["kwargs"]["external_id"]
+            )
+            return (
+                request.user.is_superuser
                 or (
                     request.user.user_type > User.TYPE_VALUE_MAP["DistrictAdmin"]
-                    and request.user.user_type <= User.TYPE_VALUE_MAP["StateAdmin"]
-                    and state == request.user.state
+                    and facility.state == request.user.state
+                )
+                or (
+                    request.user.user_type > User.TYPE_VALUE_MAP["LocalBodyAdmin"]
+                    and facility.state == request.user.state
+                    and facility.district == request.user.district
                 )
             )
         except Exception: