Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload entry for failed uploads #3582

Closed
mathew-alex opened this issue Sep 14, 2022 · 1 comment · Fixed by #3609
Closed

File upload entry for failed uploads #3582

mathew-alex opened this issue Sep 14, 2022 · 1 comment · Fixed by #3609
Assignees

Comments

@mathew-alex
Copy link
Contributor

An entry is added even in the case of a failed file upload. The preview option for the entry under View Consultation Files will not generate a preview because of that.

@Ashesh3
Copy link
Member

Ashesh3 commented Sep 14, 2022

It seems like according to the current workflow, an entry for a file is created before the actual upload takes place. The backend first creates an entry and returns the signed_url which is used on the frontend side to make the actual upload. If the upload fails, the backend has no way of knowing the same and frontend does nothing to remedy that.

Possible fix: Currently all files have an attribute upload_completed which defaults to False. Once an upload is actually successful, the frontend can send a separate request to set that to True.
The file list on the frontend would then only show files which have upload_completed = True.

@vigneshhari What's your take on this?
Edit: Discussed on EOD call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants