Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose upload_completed for FileUpload #1029

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Expose upload_completed for FileUpload #1029

merged 4 commits into from
Sep 21, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 19, 2022 •
edited
Loading

Proposed Changes

  • This PR exposes the already present upload_completed attribute for the FileUpload model, this is now used to keep track for successful file uploads.
  • The frontend will be updated to accordingly hide any incomplete file uploads and only show the ones with upload_completed = True
  • This also allows upload_completed to be modified via a PATCH request, the frontend will now send a separate PATCH to set the said field to True when the file upload is successful.
  • A migration is also included which sets upload_completed to True for all existing files.

Associated Issue

@coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team as a code owner September 19, 2022 11:30
@Ashesh3 Ashesh3 mentioned this pull request Sep 19, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vigneshhari vigneshhari merged commit b679a35 into coronasafe:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ashesh3 @vigneshhari