Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set file as uploaded on a successful upload #3609

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 19, 2022

Closes: #3582

Related PR: coronasafe/care#1029

Proposed Changes

  • On file upload, an additional PATCH is sent to mark the file upload as complete
  • Only completed file_uploads are shown to the user

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Before: [All files are shown even if the upload failed for any reason]
image

Previewing any such incomplete upload will fail, since the file was never uploaded.
image

After: [Only files marked with upload_completed = True are shown]
image

@Ashesh3 Ashesh3 requested a review from a team September 19, 2022 11:39
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 19, 2022 11:39
@netlify
Copy link

netlify bot commented Sep 19, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d454a35
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/632854ed06c3700008b2472d
😎 Deploy Preview https://deploy-preview-3609--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit d7f8449 into coronasafe:develop Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File upload entry for failed uploads
3 participants