Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Material UI components in src/Components/Facility/AssetCreate.tsx: #4945

Closed
3 tasks
Tracked by #5006
rithviknishad opened this issue Feb 28, 2023 · 8 comments · Fixed by #5553
Closed
3 tasks
Tracked by #5006

Replace Material UI components in src/Components/Facility/AssetCreate.tsx: #4945

rithviknishad opened this issue Feb 28, 2023 · 8 comments · Fixed by #5553
Assignees
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

10: import CropFreeIcon from "@material-ui/icons/CropFree";\n20: import { LocationOnOutlined } from "@material-ui/icons";

Tasks

Ensure all the below tasks are accomplished if applicable to the file being modified in the PR.

For more information see the epic issue that tracks this issue.

@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 26, 2023
@sachdevavaibhav
Copy link
Contributor

I can work on this issue. Please assign it to me.

@sachdevavaibhav
Copy link
Contributor

@khavinshankar It looks like this issue has already been fixed PR #5062. I suggest you to close this and the other issues solved by the mentioned PR.

@rithviknishad
Copy link
Member Author

@sachdevavaibhav could you replace the following legacy components used in AssetCreate? It indirectly uses MUI.

image

@sachdevavaibhav
Copy link
Contributor

@rithviknishad Sure! I am working on it.

@sachdevavaibhav
Copy link
Contributor

@rithviknishad Please review the PR #5553

@bodhish
Copy link
Member

bodhish commented May 28, 2023

@rithviknishad can we remove MUI completely?

@rithviknishad
Copy link
Member Author

@bodhish there's a lot of usage of MUI, so we have decided to make an EPIC issue (#5006) to remove file by file.

We have already got rid of MUI icons package a while back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants