Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall and replaces all Material UI icons with Care Icons #5062

Merged
merged 14 commits into from
Mar 13, 2023
Merged

Uninstall and replaces all Material UI icons with Care Icons #5062

merged 14 commits into from
Mar 13, 2023

Conversation

ayushjnv1
Copy link
Contributor

@ayushjnv1 ayushjnv1 commented Mar 8, 2023 •
edited by rithviknishad
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Mar 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 8:51AM (UTC)

@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0e10e9b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640ee368a97ea00008d87712
😎 Deploy Preview https://deploy-preview-5062--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayushjnv1 ayushjnv1 mentioned this pull request Mar 8, 2023
Closed
@ayushjnv1 ayushjnv1 marked this pull request as ready for review March 8, 2023 13:08
@ayushjnv1 ayushjnv1 requested a review from a team March 8, 2023 13:08
@ayushjnv1 ayushjnv1 requested a review from a team as a code owner March 8, 2023 13:08
@ayushjnv1 ayushjnv1 requested a review from bodhish March 8, 2023 13:08
@ayushjnv1
Copy link
Contributor Author

#5049

@rithviknishad rithviknishad changed the title Fix/#5049 Uninstall and replaces all Material UI icons with Care Icons Mar 10, 2023
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 13, 2023
@github-actions
Copy link

👋 Hi, @ayushjnv1,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@khavinshankar
Copy link
Member

@ayushjnv1 can you please resolve the merge conflicts

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Mar 13, 2023
@rithviknishad
Copy link
Member

@khavinshankar

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit d4f3b68 into ohcnetwork:develop Mar 13, 2023
@sachdevavaibhav sachdevavaibhav mentioned this pull request May 27, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of material-ui/icons
4 participants
@ayushjnv1 @nihal467 @khavinshankar @rithviknishad