Sachdevavaibhav/#4945

[sachdevavaibhav]

WHAT

Working on #4945

🤖 Generated by Copilot at 5739e28

Improved date input component by closing popover after selection. Updated setDateValue function and DateInputV2.tsx file.

Proposed Changes

• Fixes #issue?
• Change 1
• Change 2
• More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

HOW

🤖 Generated by Copilot at 5739e28

• Import MutableRefObject type from react to use as parameter type for close function (link)
• Modify setDateValue function to accept close function as second parameter and invoke it after onChange callback (link, link)
• Destructure close function from Popover component props and pass it to setDateValue function (link)
• Pass close function to setDateValue function inside onClick handler of div element that renders each date in calendar (link)
• Close popover component after user selects or clicks on a date from DateInputV2 component (link, link, link)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 27, 2023 9:03pm

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	e8bec8a
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/64726ff971d9ac00092382d2
😎 Deploy Preview	https://deploy-preview-5551--care-egov-staging.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[sachdevavaibhav]

@rithviknishad Could you please check if I am moving in the right direction?

Also did I mess up with the branches?

[rithviknishad]

Yes you did mess up your branches ig.

You've branched out from your previous PR's branch I assume.

When working on a new PR, you can simply do the following:

git checkout develop
git pull upstream develop # if you've added upstream remote, you can do this to fetch latest develop so that you always branch from latest develop (or you can simply go to your github repo and fetch latesst changes and do a git pull)
git checkout -b "your-new-branch-name"

[sachdevavaibhav]

@rithviknishad
Yes, I didn't checkout to develop. I pulled develop into the previous branch and then created a new branch. Sorry for the mess.

Any suggestions on how I can fix it?

[rithviknishad]

You could create a fresh new branch and re-open another PR and close this.

[sachdevavaibhav]

@rithviknishad
I have reverted changes in the previous branch and force pushed it (since I merged develop into it). Closing this PR and creating new one.