Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should state_logo be used instead of KeralaLogo in Resource Approval Letter? #5318

Closed
rithviknishad opened this issue Apr 11, 2023 · 0 comments
Closed

Should state_logo be used instead of KeralaLogo in Resource Approval Letter? #5318

rithviknishad opened this issue Apr 11, 2023 · 0 comments
Assignees
@aparnacoronasafe
Labels
blocked discussion required

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Apr 11, 2023 •
edited
Loading

Problem:
Currently, in all deployments, KeralaLogo is used as the header logo in the resource approval letters.

Possible Solution:
Use state_logo configured in the config.json instead if present else show no logo.

image

Originally posted by @sainak in #5305 (comment)
@rithviknishad rithviknishad changed the title Should state_logo be used instead of KeralaLogo in Resource Approval Letter Should state_logo be used instead of KeralaLogo in Resource Approval Letter? Apr 11, 2023
@rithviknishad rithviknishad mentioned this issue Apr 11, 2023
Merged
6 tasks
rithviknishad added a commit that referenced this issue Apr 11, 2023
@rithviknishad
Removed KeralaLogo in Resource Approval Letter. related to #5318
a07be5e
khavinshankar pushed a commit that referenced this issue Apr 12, 2023
@rithviknishad
Change all absolute URLs attempting to access public/static contents …
b6f01bb 
…to use relative URLs (#5305)

* fixes #5303

* Removed `KeralaLogo` in Resource Approval Letter. related to #5318
@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aparnacoronasafe aparnacoronasafe

Labels
blocked discussion required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rithviknishad @aparnacoronasafe