-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have a static loading screen in index.html
#5991
Comments
Hey @rithviknishad, is this issue open to work on? I would like to contribute to it. |
Hey @jainvedant392 Yes, it's open for contribution! |
Sure, thanks a lot. |
The index.html should show the CARE loading element (similar to the And this should be shown while the index.js is being fetched / ReactDOM.render() is executed. Attaching some references that might help: |
Sure. That was a lot help. Will try to resolve this soon. |
Hello @rithviknishad, extremely sorry for being inactive for so many days due to some unavoidable circumstances. |
But I have been working for this issue for some days and reading the code of the repo as well. |
I had a doubt, since we have used "Suspense" from 'react' in App.tsx, which configures the loading screen, so why we have have to integrate it in the index.html. |
And to do the same, I might need to disable the effect of "Suspense", am I allowed to do so? |
Have you tried removing suspense? Didn't it break? Also is there a relation between suspense and this issue? This issue is about having a loading element in the index.html before react takes over / rewrites out that element. |
Ok I think I got what you are saying, so basically, I just have to configure a Loader in index.html, which would be same as the Loading component. Am I right? |
I can place the Loader inside the "root" div, which would afterwards be overwritten by the loaded React. |
Yes, that's what the previous PR attempted. |
Ok, thanks a lot. |
CARE loading animation (similar to one which we have inside the app) should be shown while the js files are being fetched.
Refer #6012 for the first attempt on solving this.
The text was updated successfully, but these errors were encountered: