Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loading screen in index.html #6836

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Add loading screen in index.html #6836

merged 5 commits into from
Dec 13, 2023

Conversation

jainvedant392
Copy link
Contributor

@jainvedant392 jainvedant392 commented Dec 9, 2023 •
edited
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@jainvedant392 jainvedant392 requested a review from a team as a code owner December 9, 2023 18:26
@vercel Vercel
Copy link

vercel bot commented Dec 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 1:15pm

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cce3c6e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6579ae52f19ad3000825b0b0
😎 Deploy Preview https://deploy-preview-6836--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainvedant392
Copy link
Contributor Author

Hey @Ashesh3, @sainak, just a friendly reminder to please review this PR.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit cdbe306 into coronasafe:develop Dec 13, 2023
12 checks passed
@jainvedant392 jainvedant392 deleted the issue5991 branch December 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Ashesh3 Ashesh3 Awaiting requested review from Ashesh3

@sainak sainak Awaiting requested review from sainak

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have a static loading screen in index.html
4 participants
@jainvedant392 @nihal467 @rithviknishad @khavinshankar