Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked skills- to show on patient dashboard for "treating doctor" #7810

Closed
aparnacoronasafe opened this issue May 14, 2024 · 7 comments · Fixed by #7822
Closed

Linked skills- to show on patient dashboard for "treating doctor" #7810

aparnacoronasafe opened this issue May 14, 2024 · 7 comments · Fixed by #7822
Assignees
Labels
P1 breaking issue or vital feature urgent

Comments

@aparnacoronasafe
Copy link
Member

https://care.coronasafe.in/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/edfe0bd6-0f50-4a4c-8cd0-2d4ad0e9cea1

The patient dashboard shows name of the "treating doctor". After the name of the doctor, show the skills linked to the doctor within "(_)"

@aparnacoronasafe aparnacoronasafe added the P1 breaking issue or vital feature label May 14, 2024
Copy link

⚠️ Refrain from assigning this issue to yourself if you have another P1 issue assigned that is not yet closed.

@Sulochan-khadka
Copy link
Contributor

May you present some UI idea to that... I think since the skills may be large thus, having a dropdown with the heading as Skills would be better.

@Sulochan-khadka
Copy link
Contributor

I guess there are two ways in which we can achieve this...

Like this: (Dropdown)
Screenshot 2024-05-14 at 3 44 56 PM

or like this: (SlideOver)
Screenshot 2024-05-14 at 3 49 37 PM

Also let me know if it should have the functionality to unlink the skills or not.

@Sulochan-khadka
Copy link
Contributor

@aparnacoronasafe Let me know if I can help you ...

@Sulochan-khadka
Copy link
Contributor

Since this is P1, can @rithviknishad @nihal467 comment on this and let me know if I can go ahead and raise a PR?

@rithviknishad
Copy link
Member

rithviknishad commented May 14, 2024

@Sulochan-khadka The UI shown above is not suitable.

@aparnacoronasafe has already mentioned a good solution on how to show the skills in the UI in the issue comment itself. Just re-explaining...

Show a comma-separated text of skills with a limit of maybe 3. It could be a text in gray color, underlined and cursor pointer. If there are more than 3 skills, show two skills and rest can be shown in a tooltip.

Eg:

Treating Doctor:  Dr. Sam Joe  (Skill one, skill two and 3 other skills)

Feel free to create a PR since you've already achieved the functionality 😄

@aparnacoronasafe
Copy link
Member Author

@Sulochan-khadka please follow the suggestion from @rithviknishad above.

We do NOT need a button to show linked skills. It must appear on the page itself. So simply adding a text with skills in (..) should suffice.

When there are multiple skills show them one after the other separated by a comma

Sulochan-khadka added a commit to Sulochan-khadka/care_fe that referenced this issue May 15, 2024
khavinshankar pushed a commit that referenced this issue May 21, 2024
* fixes: Linked skills- to show on patient dashboard for "treating doctor" #7810

* Update src/Components/Patient/PatientInfoCard.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

* updated with implementing suggestions

* made changes

* refactor based on suggestions

* show tooltip only if overflow

* Update src/Components/Patient/PatientInfoCard.tsx

---------

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Co-authored-by: rithviknishad <mail@rithviknishad.dev>
khavinshankar pushed a commit that referenced this issue Jun 14, 2024
* fixes: Linked skills- to show on patient dashboard for "treating doctor" #7810

* Update src/Components/Patient/PatientInfoCard.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

* updated with implementing suggestions

* made changes

* refactor based on suggestions

* show tooltip only if overflow

* Update src/Components/Patient/PatientInfoCard.tsx

* fixes:Maintain aspect ratio for Bed Icon in Patient Dashboard #7971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants