Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show skills of treating doctor in consultation dashboard #7822

Merged
merged 11 commits into from
May 21, 2024
Merged

Show skills of treating doctor in consultation dashboard #7822

merged 11 commits into from
May 21, 2024

Conversation

Sulochan-khadka
Copy link
Contributor

@Sulochan-khadka Sulochan-khadka commented May 15, 2024 •
edited by rithviknishad
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sulochan-khadka Sulochan-khadka requested a review from a team as a code owner May 15, 2024 07:53
@vercel Vercel
Copy link

vercel bot commented May 15, 2024

@Sulochan-khadka is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 41011da
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/664c6659864e1a0008068571
😎 Deploy Preview https://deploy-preview-7822--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sulochan-khadka
Copy link
Contributor Author

Screenshot 2024-05-15 at 1 25 39 PM Here is the result for reference!!

rithviknishad
rithviknishad requested changes May 15, 2024
View reviewed changes
src/Components/Patient/PatientInfoCard.tsx Outdated Show resolved Hide resolved
src/Components/Patient/PatientInfoCard.tsx Outdated Show resolved Hide resolved
@rithviknishad rithviknishad added P1 breaking issue or vital feature changes required labels May 15, 2024
@Sulochan-khadka @rithviknishad
Update src/Components/Patient/PatientInfoCard.tsx
fbad5dc 
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit fbad5dc
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/6644b05c029b500008049033

@Sulochan-khadka
Copy link
Contributor Author

@rithviknishad , I have also added appropriate grammar since it was not proper then. Let me know if this PR requires some more improvements.

@rithviknishad rithviknishad removed changes required Deploy-Failed Deplyment is not showing preview labels May 15, 2024
rithviknishad
rithviknishad requested changes May 15, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The UI has improved a lot!

Few more suggestions, and should be ready for testing.

  1. If there are 3 or more skills, since we are truncating it, show those as comma-separated values inside the tooltip.

  2. Just correct the minor alignment and spacing issue. Seems to be vertically off center.

Before the PR:
image

PR:
image

@Sulochan-khadka
Copy link
Contributor Author

Nice work! The UI has improved a lot!

Few more suggestions, and should be ready for testing.

  1. If there are 3 or more skills, since we are truncating it, show those as comma-separated values inside the tooltip.
  2. Just correct the minor alignment and spacing issue. Seems to be vertically off center.

Before the PR: image

PR: image

  1. But some users have much more skills, how do I represent them? Could you give some idea about how should UI look like? A similar reference would be highly appreciated.

@rithviknishad
Copy link
Member

@Sulochan-khadka you could show all the skills as comma-separated values in the tooltip text.

Have a look at how tooltip's are used in other places. It's easy. 😄

@rithviknishad rithviknishad changed the title fixes: Linked skills- to show on patient dashboard for "treating doct… Show skills of treating doctor in consultation dashboard May 17, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1a08faf into ohcnetwork:develop May 21, 2024
28 of 30 checks passed
@github-actions GitHub Actions
Copy link

@Sulochan-khadka Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linked skills- to show on patient dashboard for "treating doctor"
4 participants
@Sulochan-khadka @rithviknishad @nihal467 @khavinshankar