Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix representation of facility name #2304

Merged
merged 4 commits into from
May 25, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented May 10, 2022

Fixes #2268

  • Added "Facility" prefix to facility representation
  • Font size increased by 114% (sm to 3xl)

Preview:
image

@Ashesh3 Ashesh3 requested a review from a team May 10, 2022 14:34
@nihal467
Copy link
Member

opewfkoew

@Ashesh3 @gigincg rather than writing the facility, can we use any symbols for a facility like hospital symbols, now it's not looking good

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 15, 2022

@nihal467 Is this better?

image

@nihal467
Copy link
Member

wpojefeopf

@Ashesh3 @gigincg i can't see any update in the PR,

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 16, 2022

wpojefeopf

@Ashesh3 @gigincg i can't see any update in the PR,

That's correct, Just wanted to get a visual feedback first if that looks good or not. if yes, I'd add the updated commit to this PR! Did that just now!

@nihal467
Copy link
Member

oekpwfwo

@Ashesh3 @gigincg the facility name and the patient name alignment is off, make the alignment proper

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 16, 2022

@nihal467 Fixed the alignment to match the padding of the patient name on the left side.

  • With inner padding on div md:pl-2 (Updated in this PR)
    image

  • Without inner padding (Not in this PR)
    image

Let me know which one works the best.

@nihal467
Copy link
Member

apokfopfaw

@Ashesh3 @gigincg test failed

  • the left side alignment is off
  • the facility name font size is big, can you reduce it a bit, or try some other font, the existing font doesn't feel matches the UI

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 17, 2022

@nihal467 Fixed the left alignment, reduced the facility name font size, made it semi bold to match it more with the surrounding elements.

image

@nihal467
Copy link
Member

psajfojasf

@Ashesh3 the alignment of created, diagnosis, and verified by is off, when we compared to the top

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 17, 2022

psajfojasf

@Ashesh3 the alignment of created, diagnosis, and verified by is off, when we compared to the top

Fixed the alignment of the said elements.

image

@nihal467
Copy link
Member

nihal467 commented May 17, 2022

wekofewop

@Ashesh3 now, everything is aligned, but make it aligned to the line present under the blood group

pwkefoepk

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 17, 2022

All the elements are now aligned to the line below the blood group.

image

@nihal467
Copy link
Member

nihal467 commented May 18, 2022

@Ashesh3 @gigincg check the conflicting files !

@nihal467
Copy link
Member

nihal467 commented May 18, 2022

wepokfewokpf

@Ashesh3 @gigincg reduce the spacing between the borderline and the content

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 18, 2022

Reduced the spacing

image

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 37daa7a into coronasafe:develop May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility name : Representation Error : UI
5 participants