Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UI for Patient info card. Also shifted patient discharge buttons under the info card #2563

Merged
merged 9 commits into from
Jun 16, 2022

Conversation

skks1212
Copy link
Member

closes #2316
closes #2405

image
image

Reduced card height as much as possible.

@nihal467
Copy link
Member

@skks1212 @gigincg the deploy preview is failed

@rithviknishad
Copy link
Member

@skks1212 deploy preview is failing. merge the latest develop branch.

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed test failed labels May 31, 2022
@skks1212 skks1212 added needs testing and removed Deploy-Failed Deplyment is not showing preview labels May 31, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 2, 2022

3

@skks1212 @gigincg can you align the right side and left side equally on the top and bottom? I feel it is in a different alignment, what are your opinions!

@skks1212
Copy link
Member Author

skks1212 commented Jun 2, 2022

@nihal467 I feel we should not center align it as per design. If you say we should, il add a commit, but I personally think this looks better and more "profiley"

@nihal467
Copy link
Member

nihal467 commented Jun 2, 2022

@skks1212 @gigincg I meant to bring the left side a little bit lower so that it is aligned with the right side

@skks1212 skks1212 requested a review from a team as a code owner June 2, 2022 17:50
@skks1212
Copy link
Member Author

skks1212 commented Jun 2, 2022

@nihal467 changes done

@nihal467
Copy link
Member

nihal467 commented Jun 4, 2022

test approved

@khavinshankar
Copy link
Member

@skks1212 please do work on the merge conflict

@skks1212
Copy link
Member Author

@skks1212 please do work on the merge conflict

@khavinshankar done

@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 2bf0185
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a33cb80428e3398bb427b9

@khavinshankar
Copy link
Member

@skks1212 please do check out the deploy issue and also do work on the merge conflict

@khavinshankar
Copy link
Member

khavinshankar commented Jun 10, 2022

@skks1212 can you please check this out,
image
the build is failing because of this

The problem most likely is there is no onClick in RoleButton component, maybe named different

@skks1212
Copy link
Member Author

@khavinshankar hopefully that solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI for patient info card buttons Discharge and Discharge Summary
5 participants