Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Bed or Switch Bed button is visible only for Live Patients #2675

Closed
wants to merge 3 commits into from

Conversation

patelaryan7751
Copy link
Contributor

Fixes #2673

Bugs Fixed

Assign Bed or Switch Bed button is visible only for Live Patients

image

@patelaryan7751 patelaryan7751 requested a review from a team June 11, 2022 07:26
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 11, 2022 07:26
@vercel
Copy link

vercel bot commented Jun 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 2:08AM (UTC)

@netlify
Copy link

netlify bot commented Jun 11, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 03704b3
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a443b0e351060009d5c93a

@patelaryan7751
Copy link
Contributor Author

Deploy Preview Ready https://deploy-preview-2675--care-net.netlify.app/

@shivankacker
Copy link
Member

Hey @patelaryan7751 can you add this as a commit to #2563 and close this pr ?
Because the UI will be completely changing with that PR so...

@nihal467
Copy link
Member

test approved

@patelaryan7751 patelaryan7751 marked this pull request as ready for review June 20, 2022 02:08
@patelaryan7751
Copy link
Contributor Author

Done Changes as per new UI #2563

@patelaryan7751
Copy link
Contributor Author

Deploy Preview Ready https://deploy-preview-2675--care-net.netlify.app/

Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than removing the button alltogether, can you change it to "Bed History" and make the modal only show the assigned beds table and not let them add any?

@patelaryan7751
Copy link
Contributor Author

@skks1212 yeah right. Nice idea i am working on it.

@nihal467 nihal467 added question Further information is requested and removed needs testing labels Jun 22, 2022
@nihal467
Copy link
Member

@patelaryan7751 is it good for testing, saw a comment mentioning you are working

@patelaryan7751
Copy link
Contributor Author

@nihal467 i am working on it

@aeswibon aeswibon added work-in-progress and removed question Further information is requested labels Jun 23, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@patelaryan7751 patelaryan7751 deleted the issue#2673 branch July 14, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After a patient is discharged from CARE the switch bed option should be hidden
4 participants