Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: white space on smaller device #2579

Merged
merged 5 commits into from
Jul 6, 2022

Conversation

kunatastic
Copy link
Contributor

fixes #2577

Consistent white space even on smaller devices

image

@kunatastic kunatastic requested a review from a team May 29, 2022 17:45
@nihal467
Copy link
Member

@kunatastic @gigincg the deployment preview is failed

@rithviknishad
Copy link
Member

@kunatastic deploy preview is failing. merge the latest develop branch.

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed test failed labels May 31, 2022
@kunatastic kunatastic added needs testing and removed Deploy-Failed Deplyment is not showing preview labels May 31, 2022
@nihal467
Copy link
Member

nihal467 commented Jun 1, 2022

@kunatastic @gigincg test failed, make the page responsive, asset advance filter button and all are not responsive

@kunatastic kunatastic requested a review from a team as a code owner June 8, 2022 17:31
@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit 8e99319
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62a0dcfcd5ea3a0008f7cb8d

@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@kunatastic
Copy link
Contributor Author

Updated UI:
image

Previously:
image

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

test approved

@khavinshankar khavinshankar merged commit 425bc9e into coronasafe:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional white space on smaller devices on asset page
7 participants