Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changed layout of individual user cards in user management page #2590

Merged
merged 6 commits into from
Jun 2, 2022
Merged

feat: changed layout of individual user cards in user management page #2590

merged 6 commits into from
Jun 2, 2022

Conversation

Pragati1610
Copy link
Contributor

@Pragati1610 Pragati1610 commented May 30, 2022 •
edited
Loading

Fixes #2435

  • Removed the extra space in each card
  • Changed the look of individual facilities
  • Made 3 columns instead of 2 columns

Before:
image

After
image

@Pragati1610 Pragati1610 requested a review from a team May 30, 2022 14:01
@nihal467
Copy link
Member

test approved

@sainak
Copy link
Member

sainak commented May 30, 2022

@Pragati1610 delete the package-lock from your branch as we have started using yarn.

developedBySJ
developedBySJ suggested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Layout is not responsive!

Use 3 col layout for lg breakpoint

image

src/Components/Common/ClosingTag.tsx Outdated Show resolved Hide resolved
src/Components/Common/ClosingTag.tsx Outdated Show resolved Hide resolved
developedBySJ
developedBySJ approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar merged commit b9330f6 into coronasafe:develop Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp User Management UI
5 participants
@Pragati1610 @nihal467 @sainak @khavinshankar @developedBySJ