Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Asset Class field and Improve Asset Type option's descriptions #2653

Merged
merged 13 commits into from
Jun 23, 2022

Conversation

rithviknishad
Copy link
Member

Closes #2431
Closes #2432

Re-work of #2552 as I'm unable to develop on that branch as system freezes every time I do yarn start on that.

2022-06-06.16-13-57.mp4

@rithviknishad rithviknishad requested a review from a team June 6, 2022 10:52
@rithviknishad rithviknishad requested a review from a team as a code owner June 6, 2022 10:52
@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

1

@rithviknishad @gigincg test failed, the UI doesn't look good

@rithviknishad
Copy link
Member Author

@nihal467 I'm using the native rendering which was used originally 🥲 Just used a better description instead of External and Internal.

Could you give me some suggestions to improve?

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

172045750-1654c71d-96fe-4be1-93cc-2826956df84b

@rithviknishad @gigincg this one looks good, just my opinion @gigincg what do you think

@rithviknishad
Copy link
Member Author

@nihal467 will try working on it.
that one was using non-native rendering and had issues with different browsers when you tested in #2552 so decided to use the original style itself.

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview Failed. CC: @rithviknishad

Name Link
🔨 Latest commit ebcc4a2
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/62ac584124ea380009d9db6c

@rithviknishad
Copy link
Member Author

@nihal467 @gigincg how about this one?
If mobile, shows the asset type's hint below the selected option.
If not mobile, shows a tooltip on hover.

Couldn't get the above design to work on chrome.

image

@gigincg
Copy link
Member

gigincg commented Jun 10, 2022

@rithviknishad lets do the tailwind dropdown that we discussed. Ping me if you need any help

@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-fe ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 8:57AM (UTC)

@rithviknishad
Copy link
Member Author

image

@rithviknishad
Copy link
Member Author

Select menu implemented as part of #2776

@rithviknishad
Copy link
Member Author

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 0e595f9 into coronasafe:develop Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants