Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Configure Asset button if !asset_class #2654

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

rithviknishad
Copy link
Member

Closes #2649

2022-06-06.16-33-04.mp4

@rithviknishad rithviknishad requested a review from a team June 6, 2022 11:06
@rithviknishad rithviknishad requested a review from a team as a code owner June 6, 2022 11:06
Copy link
Contributor

@ishanExtreme ishanExtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Jun 8, 2022

@rithviknishad @gigincg how we will be assigning the asset class, currently unable to find it in the existing PR

@nihal467 nihal467 added question Further information is requested and removed needs testing labels Jun 8, 2022
@rithviknishad
Copy link
Member Author

@nihal467 #2653 has Asset Class field implemented. This PR does not include that PR branch as base.

An asset with asset class defined: https://deploy-preview-2654--care-net.netlify.app/assets/15e5b3e0-c991-418d-b21d-b51c5369e213

An asset without asset class defined: https://deploy-preview-2654--care-net.netlify.app/assets/86c5fc30-98c7-45ad-855f-2c59cc7d2fd2

@rithviknishad rithviknishad added needs testing and removed question Further information is requested labels Jun 8, 2022
@nihal467 nihal467 added waiting for related PR a co-related detail PR is under construction and removed needs testing labels Jun 8, 2022
@rithviknishad rithviknishad added needs testing needs review and removed waiting for related PR a co-related detail PR is under construction labels Jun 23, 2022
@aeswibon aeswibon mentioned this pull request Jun 23, 2022
6 tasks
@gitguardian
Copy link

gitguardian bot commented Jun 27, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
757392 Google API Key 2cec8ae src/Common/env.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rithviknishad
Copy link
Member Author

@nihal467

@nihal467
Copy link
Member

nihal467 commented Jul 2, 2022

@rithviknishad unable to find the asset class, can you merge the latest staging version to this PR, so it can be tested

@rithviknishad
Copy link
Member Author

@nihal467

image

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

@rithviknishad

11

iam unable to modify the asset class to nil, once the asset is created

@nihal467
Copy link
Member

nihal467 commented Jul 3, 2022

test approved

@khavinshankar khavinshankar merged commit cc0e587 into ohcnetwork:develop Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the Configure button if asset_class = null
5 participants