Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped: Resource Request Page #3172

Closed
wants to merge 5 commits into from
Closed

Revamped: Resource Request Page #3172

wants to merge 5 commits into from

Conversation

aeswibon
Copy link
Member

Updates

@aeswibon aeswibon requested a review from a team July 20, 2022 17:37
@aeswibon aeswibon requested a review from a team as a code owner July 20, 2022 17:37
@aeswibon aeswibon requested a review from giju July 20, 2022 17:37
@netlify
Copy link

netlify bot commented Jul 20, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5180850
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62ffe0ebbf394a0009b8b28a
😎 Deploy Preview https://deploy-preview-3172--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

developedBySJ
developedBySJ suggested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-Coder Please add a preview screenshot 🙂

src/Components/Resource/ResourceCreate.tsx Outdated Show resolved Hide resolved
@aeswibon
Copy link
Member Author

@cp-Coder Please add a preview screenshot 🙂

image

@nihal467
Copy link
Member

@cp-Coderimage

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2022

@cp-Coder
image

  • i can scroll down a lot

@aeswibon
Revamped the UI
3e6d4c6
@aeswibon
Removed unused imports
90acbf8
@aeswibon
Fixed position issue
9c8d936
@aeswibon
Refactored the code:
6d950a6 
- Replaced state variable with state.form
- Using useReducer dispatch to set the state.form variable
@aeswibon
Formatted the code
5180850
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aeswibon
Copy link
Member Author

@nihal467 I am not facing such issue
image

@nihal467
Copy link
Member

@cp-Coder test failed,

image

  • make the page responsive
  • make the cancel and submit button in two lines in the responsive view with the same length

image

  • can we have the emergency button on the same line as category and subcategory are there, its just an opinion, before working on this, taking a second opinion also will be good

@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 27, 2022
@mathew-alex
Copy link
Contributor

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon
Copy link
Member Author

aeswibon commented Oct 2, 2022

Fixed in PR #3547

@aeswibon aeswibon closed this Oct 2, 2022
@aeswibon aeswibon deleted the issue#2976 branch October 2, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developedBySJ developedBySJ developedBySJ requested changes

@giju giju Awaiting requested review from giju

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict test failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp : Resource Request Page
4 participants
@aeswibon @nihal467 @mathew-alex @developedBySJ