Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped Create Resource Request page #3547

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Revamped Create Resource Request page #3547

merged 5 commits into from
Sep 21, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3546
http://localhost:4000/facility/3447b03d-7522-4525-9e14-58d7628b1e9e/resource/new

  • Removed white spaces between the form
    image
  • Placed the buttons in a column in mobile view
    image

@Pranshu1902 Pranshu1902 requested a review from a team September 6, 2022 07:12
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 6, 2022 07:12
@netlify
Copy link

netlify bot commented Sep 6, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a7a083a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6323121b4bfdf80008d6f2bb
😎 Deploy Preview https://deploy-preview-3547--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Sep 7, 2022

@Pranshu1902
image

make the alignment proper

@Pranshu1902
Copy link
Contributor Author

@nihal467 Updated view:
image

@nihal467
Copy link
Member

@Pranshu1902 merge the latest development branch

@nihal467 nihal467 added question Further information is requested and removed needs testing labels Sep 12, 2022
@Pranshu1902 Pranshu1902 added needs testing and removed question Further information is requested labels Sep 12, 2022
@nihal467
Copy link
Member

@Pranshu1902
image

  • the Ui is still off alignment,
  • check the cypress test, it is failing

@nihal467 nihal467 added test failed Cypress Test Pending The Cypress test are to be verified and removed needs testing labels Sep 14, 2022
@Pranshu1902
Copy link
Contributor Author

@nihal467
updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@Pranshu1902
Copy link
Contributor Author

@nihal467 Staging BE can't handle the speed of cypress that's why it is failing

@Pranshu1902 Pranshu1902 removed the Cypress Test Pending The Cypress test are to be verified label Sep 16, 2022
@nihal467
Copy link
Member

test approved, since Vignesh asked to neglect the cypress crashing as backend is timeout

@khavinshankar khavinshankar merged commit db86321 into coronasafe:develop Sep 21, 2022
@aeswibon aeswibon mentioned this pull request Oct 2, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp Create Resource Request Page
3 participants
@Pranshu1902 @nihal467 @khavinshankar