Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Patient Tab Unresponsive #3295

Merged
merged 7 commits into from
Sep 8, 2022
Merged

Fix: Patient Tab Unresponsive #3295

merged 7 commits into from
Sep 8, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #3233

Preview:
image

@GokulramGHV GokulramGHV requested a review from a team August 2, 2022 02:12
@GokulramGHV GokulramGHV requested a review from a team as a code owner August 2, 2022 02:12
@netlify
Copy link

netlify bot commented Aug 2, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9f58d91
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6319b99c173f9f000908e2bc
😎 Deploy Preview https://deploy-preview-3295--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

developedBySJ
developedBySJ approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Aug 3, 2022

@GokulramGHV
image

make live patient and download button of same length

@GokulramGHV
Copy link
Member Author

@nihal467
image

@nihal467
Copy link
Member

nihal467 commented Aug 9, 2022

@GokulramGHV
image

can you make the advance filter responsive

@GokulramGHV GokulramGHV mentioned this pull request Aug 13, 2022
Closed
@GokulramGHV
Copy link
Member Author

@nihal467
image

@patelaryan7751
Copy link
Contributor

Hey @nihal467 i am also working on the filter modal responsiveness on a different issue #3386

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Aug 19, 2022
@GokulramGHV GokulramGHV removed the merge conflict pull requests with merge conflict label Aug 21, 2022
@khavinshankar khavinshankar added merge conflict pull requests with merge conflict and removed tested labels Aug 25, 2022
@GokulramGHV GokulramGHV added tested and removed merge conflict pull requests with merge conflict labels Aug 25, 2022
@nihal467 nihal467 added Cypress Test Pending The Cypress test are to be verified and removed tested labels Sep 5, 2022
@nihal467
Copy link
Member

nihal467 commented Sep 5, 2022

@GokulramGHV merge the latest development branch and check whether the cypress is passing or not

@nihal467 nihal467 added the tested label Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 1f48692 into coronasafe:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@patelaryan7751 patelaryan7751 patelaryan7751 approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@aeswibon aeswibon aeswibon approved these changes

@tomahawk-pilot tomahawk-pilot Awaiting requested review from tomahawk-pilot

Assignees
No one assigned
Labels
Cypress Test Pending The Cypress test are to be verified tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient tab is unresponsive
7 participants
@GokulramGHV @nihal467 @patelaryan7751 @Ashesh3 @khavinshankar @developedBySJ @aeswibon