Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advanced filter modal is now responsive in small devices #3386

Merged
merged 2 commits into from
Aug 25, 2022
Merged

advanced filter modal is now responsive in small devices #3386

merged 2 commits into from
Aug 25, 2022

Conversation

patelaryan7751
Copy link
Contributor

Fixes #3383

Proposed Changes

  • The advanced filter modal in the patient dashboard is responsive now.

image

@coronasafe/reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team August 12, 2022 11:08
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner August 12, 2022 11:08
@netlify
Copy link

netlify bot commented Aug 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d2fa296
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62fb9eb86991020009baf400
😎 Deploy Preview https://deploy-preview-3386--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

arpancodes
arpancodes suggested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@arpancodes arpancodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the same in the facility advanced filter.

image

@patelaryan7751 patelaryan7751 mentioned this pull request Aug 15, 2022
Merged
@nihal467
Copy link
Member

@patelaryan7751 once the work is done, change the label to need testing

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor Author

@arpancodes It's done
image

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar requested review from arpancodes and removed request for giju August 25, 2022 02:22
@gigincg gigincg merged commit a6f21b0 into coronasafe:develop Aug 25, 2022
@gigincg
Copy link
Member

gigincg commented Aug 25, 2022

@patelaryan7751 Consider making i18n Changes for Generic Texts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@arpancodes arpancodes Awaiting requested review from arpancodes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced filter modal not responsive in small mobile devices
5 participants
@patelaryan7751 @nihal467 @gigincg @khavinshankar @arpancodes