New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest npm in README #3545

Merged

khavinshankar merged 5 commits into coronasafe:develop from Ashesh3:include-yarn

Sep 14, 2022

Member

Ashesh3 commented Sep 6, 2022 •

edited

Loading

Since npm is the main package manager used at the moment, the README should have npm hints instead of yarn.


          Switch lockfile to Yarn and include in git

c8b5dc1

Ashesh3 requested a review from a team

September 6, 2022 04:58

Ashesh3 requested a review from a team as a code owner

September 6, 2022 04:58

Ashesh3 requested a review from mathew-alex

September 6, 2022 04:58

netlify bot commented Sep 6, 2022 •

edited

Loading

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`12e30ac`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/631737ffeb25e700094d4e94
😎 Deploy Preview	https://deploy-preview-3545--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ashesh3 mentioned this pull request

Migrate bs-webapi to rescript-webapi #3544

Merged

Ashesh3 added the needs testing label

Ashesh3 added 4 commits

September 6, 2022 10:36


          Use yarn in Dockerfile

b7c38ee


          Revert "Use yarn in Dockerfile"

d02b365

This reverts commit b7c38ee.


          Revert "Switch lockfile to Yarn and include in git"

02954b6

This reverts commit c8b5dc1.


          Suggest to use npm

12e30ac

Ashesh3 changed the title ~~Switch lockfile to Yarn and include in git~~ Suggest npm in README

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

khavinshankar approved these changes

View reviewed changes

khavinshankar added good to merge and removed needs testing labels

khavinshankar merged commit 1385f65 into coronasafe:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment