Migrate bs-webapi to rescript-webapi #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
gigincg
reviewed
Sep 5, 2022
Merged
This reverts commit 18616dc.
Apologies for the confusion, Added now! |
|
@khavinshankar check this |
|
@Ashesh3 can you merge the latest develop branch |
Done. |
|
Kudos, SonarCloud Quality Gate passed!
|
khavinshankar
approved these changes
Sep 20, 2022
khavinshankar
added
good to merge
and removed
question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3543
bs-webapiis deprecated. This PR migrates the package torescript-webapiThis was not just a drop-in replacement and needed minor changes to make it work with the new package.
Migration guide followed : TheSpyder/rescript-webapi#58