Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete button visibility on Facility Users page #3654

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Fix delete button visibility on Facility Users page #3654

merged 3 commits into from
Sep 29, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 27, 2022

Fixes #3640

Proposed Changes

  • Makes the showDelete function consistent with User Management page.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Before:
image
image

After:
image
image

@Ashesh3 Ashesh3 requested a review from a team September 27, 2022 06:25
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 27, 2022 06:25
@netlify
Copy link

netlify bot commented Sep 27, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit eb8a0b2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6333e1a452124600083dbb5d
😎 Deploy Preview https://deploy-preview-3654--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Sep 28, 2022 •
edited
Loading

@Ashesh3
image

lot of white space is been wasted for a single button, to better the experience, you can take an opinion in the EOD call and work on it

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 28, 2022

@Ashesh3 image

lot of white space is been wasted for a single button, to better the experience, you can take an opinion in the EOD call and work on it

That's totally unintentional, the delete button should be consistent with how it appears on the Users page. Should be fixed and should be just the way it is on Users page. Could you test it once again now?

User Management Page:
image

Facility Users Page:
image

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
31.6% 31.6% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 3a60bc8 into coronasafe:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete button not shown for users in Facility Users page.
3 participants
@Ashesh3 @nihal467 @khavinshankar