Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added show details modal in preview mode for PressureSore #3952

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Added show details modal in preview mode for PressureSore #3952

merged 7 commits into from
Nov 17, 2022

Conversation

khavinshankar
Copy link
Member

Fixes #3917

Proposed Changes

  • added show details modal in preview on hover
  • show push score value in badges instead of scale values
  • remapped colors based on push score

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team November 4, 2022 15:18
@khavinshankar khavinshankar requested a review from a team as a code owner November 4, 2022 15:18
@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5157a86
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63748840f2f1070008104e10
😎 Deploy Preview https://deploy-preview-3952--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 6:52AM (UTC)

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 4, 2022
@khavinshankar khavinshankar added needs testing and removed cypress failed pull request with cypress test failure labels Nov 5, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

@khavinshankar
image

in mobile view, we can't have the hover pop-up by clicking on the parts

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 9, 2022
@khavinshankar khavinshankar removed the cypress failed pull request with cypress test failure label Nov 10, 2022
@nihal467
Copy link
Member

@khavinshankar

  • the hover effect is keep on malfunctioning.

https://screen-recorder-bucket.s3.ap-south-1.amazonaws.com/ScreenRecorder_2022-11-10_8302376a-8042-4d90-a7db-bc26fe96c61f.mp4

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 16, 2022
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar removed the cypress failed pull request with cypress test failure label Nov 17, 2022
@gigincg gigincg merged commit 82cea4c into develop Nov 17, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@khavinshankar @aeswibon
Added show details modal in preview mode for PressureSore (coronasafe…
3912444 
…#3952)
@sainak sainak deleted the fix#3917 branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push score is not working properly in the critical care page of patient consultation page
3 participants
@khavinshankar @nihal467 @gigincg