Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with 3965 4004 3920 #4017

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 10, 2022

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

rithviknishad and others added 26 commits November 1, 2022 16:18
@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 3:59AM (UTC)

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f8c8e4e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636dc826f0446a0009e5c4f8
😎 Deploy Preview https://deploy-preview-4017--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Nov 10, 2022

@rithviknishad
image

the problem which got solved on facility page is showing up on the asset page, shall we take that as a separate issue, or is it correlated

@nihal467
Copy link
Member

@rithviknishad
image

the same is happening in user management page

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@rithviknishad @nihal467

There seem to be some side effects:
Steps:
in facilities page

  1. Search something in the facility search
  2. Remove the search term
  3. Now try to change page
  4. *Problem: * the page seems to reset to 1

also test the same in others too

@nihal467 lets hold this on for next production release

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 12, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member Author

rithviknishad commented Nov 12, 2022

Closing as base PR #4004 is closed, base PR #3920 is merged and a follow-up PR was made to fix the side-effect caused by the new Search Input in #4037.
The only issue left to solve is resetting to page 1 when filters are updated and will be continued in a new branch / PR since this PR contains many hacks to solve multiple issues present before and has diverged from the intended fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done merge conflict pull requests with merge conflict needs review P1 breaking issue or vital feature test failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues in #4009 Facility search not working properly
5 participants