Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4025: Default Value for hideBack prop #4026

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix 4025: Default Value for hideBack prop #4026

merged 2 commits into from
Dec 1, 2022

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Nov 10, 2022 •
edited by GokulramGHV
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@gigincg gigincg requested a review from a team November 10, 2022 14:35
@gigincg gigincg requested a review from a team as a code owner November 10, 2022 14:35
@gigincg gigincg requested a review from bodhish November 10, 2022 14:35
@gigincg gigincg linked an issue Nov 10, 2022 that may be closed by this pull request
Default value for hideBack Attribute; Remove unnecessary references #4025
Closed
@vercel
Copy link

vercel bot commented Nov 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 2:27PM (UTC)

@netlify
Copy link

netlify bot commented Nov 10, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit edd63bf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638767a1bfebfd000897e1b7
😎 Deploy Preview https://deploy-preview-4026--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Nov 10, 2022
@github-actions
Copy link

👋 Hi, @gigincg,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 25, 2022
@gigincg gigincg added needs testing and removed merge conflict pull requests with merge conflict stale cypress failed pull request with cypress test failure labels Nov 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 30, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 1, 2022

@khavinshankar review the PR

@khavinshankar khavinshankar merged commit cfd619d into develop Dec 1, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 7, 2022
@gigincg @aeswibon
Minor Refactor; Fix Linting Errors (ohcnetwork#4026)
7ba3358
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@gigincg @aeswibon
Minor Refactor; Fix Linting Errors (ohcnetwork#4026)
49d503e
@sainak sainak deleted the 4025-default-value-for-hideback-attribute-remove-unnecessary-references branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for hideBack Attribute; Remove unnecessary references
4 participants
@gigincg @nihal467 @Ashesh3 @khavinshankar