Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed card height inconsistency in PatientHome #4278

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Fixed card height inconsistency in PatientHome #4278

merged 3 commits into from
Dec 17, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team December 12, 2022 06:58
@khavinshankar khavinshankar requested a review from a team as a code owner December 12, 2022 06:58
@vercel
Copy link

vercel bot commented Dec 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 16, 2022 at 0:39AM (UTC)

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d675ba5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639c66b340714e0008b85763
😎 Deploy Preview https://deploy-preview-4278--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Dec 12, 2022
@nihal467
Copy link
Member

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Dec 16, 2022
@gigincg gigincg merged commit 0fc0fb8 into develop Dec 17, 2022
@sainak sainak deleted the fix#4115 branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

Assignees
No one assigned
Labels
needs review P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Time is breaking patient detail page UI
3 participants
@khavinshankar @nihal467 @gigincg