Added 11 digit restriction for toll free numbers

[skks1212]

Proposed Changes

• Fixes Modify customer care number condition in asset creation page #4289
• Allows 11 digits only if they start from 1800

Backend Changes Required

• Waiting for Added validation for 11 digit toll free numbers care#1121 to be merged.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
care-storybook	✅ Ready (Inspect)	Visit Preview	Dec 18, 2022 at 6:05AM (UTC)

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	6ffc143
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/639ead59188592000805943f
😎 Deploy Preview	https://deploy-preview-4294--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[nihal467]

@skks1212 Currently, there is no limit for the number on the platform, which doesn't look good.

is it possible only for the customer care number inside the asset creation form to have 11 number restrictions? and all other phone numbers remain to have 10 number restriction

@gigincg @khavinshankar what are your opnion

[khavinshankar]

@nihal467 @skks1212 I agree, may be on top of it we could have some kind of isValidPhoneNumber regex or function to validate it 🤔

[skks1212]

@nihal467 @gigincg @khavinshankar I have now only allowed 11 digits to be entered if the number starts with 1800

[nihal467]

@skks1212

https://deploy-preview-4294--care-net.netlify.app/facility/4f83b5ff-7683-499f-b330-3f49b85fef23/assets/52270b31-9248-4e6e-8e5d-350f179c078d

I am not able to submit the asset form

[skks1212]

@nihal467 will have to create a backend PR to handle backend validation. Marking PR as waiting

[nihal467]

@skks1212

still not working

[khavinshankar]

@skks1212 can you check this and clear it out as soon as possible

[nihal467]

@skks1212 the PR is not working

[skks1212]

@khavinshankar @nihal467 There appears to be a problem with care backend not deploying. Im adding a waiting for backend label to the PR again.

[skks1212]

@nihal467

Looks like Deploy issue has been fixed. Can you try testing again? 🥲

[nihal467]

@skks1212 https://app.flonnect.com/view/video/nihalcct/639ea4a6f31aaa756ef93aa9

when we are typing 18001801234, there is a bouncing happening after the number 1800,

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

[nihal467]

@khavinshankar

now the normal phone number has become 11 digit and it is not the solution we discussed

[khavinshankar]

@nihal467 merging this pr as it is a p1 issue, following this issue in a new pr

[nihal467]

@khavinshankar @skks1212 conditionally approving this solution, as it is temporarily solving purpose, but the improved solution needs to be pushed before next week's release.