Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for 11 digit toll free numbers #1121

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Added validation for 11 digit toll free numbers #1121

merged 2 commits into from
Dec 16, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Dec 14, 2022 •
edited
Loading

Proposed Changes

  • Implements a new regex validator called phone_number_regex_11 that can validate toll free numbers
  • This validator is currently only being used in asset support_phone field

Associated Issues

@coronasafe/code-reviewers

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete

@skks1212 skks1212 requested a review from a team as a code owner December 14, 2022 18:21
@skks1212 skks1212 added the P1 High priority; urgent label Dec 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skks1212 skks1212 mentioned this pull request Dec 14, 2022
Merged
6 tasks
@gigincg gigincg merged commit a4c1781 into master Dec 16, 2022
@sainak sainak deleted the phone-11 branch June 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

Assignees
No one assigned
Labels
P1 High priority; urgent waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skks1212 @gigincg