Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 11 digits only when a phone number starts with 1800 #4366

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Allow 11 digits only when a phone number starts with 1800 #4366

merged 4 commits into from
Dec 23, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team December 19, 2022 11:28
@khavinshankar khavinshankar requested a review from a team as a code owner December 19, 2022 11:28
@vercel
Copy link

vercel bot commented Dec 19, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 6:58AM (UTC)

@netlify
Copy link

netlify bot commented Dec 19, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit af7ece9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a55131091f7000092d79cb
😎 Deploy Preview https://deploy-preview-4366--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@khavinshankar
image

https://deploy-preview-4366--care-net.netlify.app/facility/7ab27974-32c8-4e36-bdf9-dbf102524718/assets/ab12b691-5769-4e6f-a6d1-d6d2028dca07/update

unable to input 11 digits into the asset form

@khavinshankar khavinshankar changed the title Allow 11 digits only when a phone number starts with 18001 Allow 11 digits only when a phone number starts with 1800 Dec 21, 2022
@nihal467
Copy link
Member

@khavinshankar
image

error persist, unable to input 11 digit in the platform

@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@mathew-alex mathew-alex merged commit 1c0452c into develop Dec 23, 2022
@sainak sainak deleted the fix#4365 branch January 19, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skks1212 skks1212 skks1212 approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow 11 digits only when a phone number starts with 18001
4 participants
@khavinshankar @nihal467 @skks1212 @mathew-alex