Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperated hook and component in useExport #4376

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Seperated hook and component in useExport #4376

merged 2 commits into from
Dec 23, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team December 20, 2022 13:32
@khavinshankar khavinshankar requested a review from a team as a code owner December 20, 2022 13:32
@vercel
Copy link

vercel bot commented Dec 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 23, 2022 at 6:02AM (UTC)

@netlify
Copy link

netlify bot commented Dec 20, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 862e626
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a544148a18f00008283e14
😎 Deploy Preview https://deploy-preview-4376--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar
Copy link
Member Author

@nihal467 while testing this pr, do also test all the export buttons if they are working as intended

@nihal467
Copy link
Member

@khavinshankar Export looks good to me, can you check he rithvik comment

@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathew-alex mathew-alex merged commit 43e1d0f into develop Dec 23, 2022
@sainak sainak deleted the fix#4353 branch January 19, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add patient details button is jumping when we open advanced patient filters
4 participants
@khavinshankar @nihal467 @rithviknishad @mathew-alex