Added support for xlsx files in Asset Import #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ashesh3
approved these changes
Dec 28, 2022
| @@ -41,17 +43,39 @@ const AssetImportModal = ({ open, onClose, facility }: Props) => { | |||
| }); | |||
| }, []); | |||
|
|
|||
| // window["parsePhone"] = parsePhoneNumberFromString; | |||
There was a problem hiding this comment.
Suggested change
| // window["parsePhone"] = parsePhoneNumberFromString; | |
| // window["parsePhone"] = parsePhoneNumberFromString; |
Seems like this can be removed.
github-actions
bot
added
the
cypress failed
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
added
cypress failed
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
xlsxfiles in Asset Importread-excel-file(its a lightweight package for reading data from excel)csvfilesExcel File Template:
https://docs.google.com/spreadsheets/d/11JaEhNHdyCHth4YQs_44YaRlP77Rrqe81VSEfg1glko/edit?usp=sharing
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist