Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to home page on sidebar logo #4634

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

skks1212
Copy link
Member

Proposed Changes

  • Previously sidebar logo was not clickable
  • Conventionally logos should redirect to home page

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team January 19, 2023 03:30
@skks1212 skks1212 requested a review from a team as a code owner January 19, 2023 03:30
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Jan 19, 2023 at 3:30AM (UTC)

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9a18ce6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63c8b9533309a60009e6e8de
😎 Deploy Preview https://deploy-preview-4634--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jan 19, 2023
@nihal467
Copy link
Member

LGTM @skks1212 check the cypress

@khavinshankar khavinshankar merged commit e93d8eb into develop Jan 24, 2023
@sainak sainak deleted the logo-redirect branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants