Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized home facility update sidebar and changed designs #4680

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Optimized home facility update sidebar and changed designs #4680

merged 3 commits into from
Feb 3, 2023

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Jan 27, 2023 •
edited
Loading

Proposed Changes

After
image

Before
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team January 27, 2023 04:11
@skks1212 skks1212 requested a review from a team as a code owner January 27, 2023 04:11
@skks1212 skks1212 requested a review from bodhish January 27, 2023 04:11
@vercel
Copy link

vercel bot commented Jan 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 28, 2023 at 2:15PM (UTC)

@netlify
Copy link

netlify bot commented Jan 27, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 62802a4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d52d60011c720008b07ffa
😎 Deploy Preview https://deploy-preview-4680--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Jan 27, 2023
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jan 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 96e4c7d into develop Feb 3, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@skks1212 @rabilrbl
Optimized home facility update sidebar and changed designs (#4680)
4715075
@sainak sainak deleted the sidebar-home-facility branch February 21, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement : View user facility slideover
3 participants
@skks1212 @nihal467 @khavinshankar