Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves malfunctioning Add Doctor Capacity form #5054

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Mar 7, 2023

Fixes #5053
http://localhost:4000/facility/6fa5e305-7eea-4b48-b973-e0679e30f63e

  • Show error message on form submission
  • Change the border color of the dropdown to red for required fields on error

Before:
image

After:
image

@Pranshu1902 Pranshu1902 requested a review from a team March 7, 2023 12:06
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner March 7, 2023 12:06
@Pranshu1902 Pranshu1902 requested a review from gigincg March 7, 2023 12:06
@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 13, 2023 at 1:09PM (UTC)

@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9eab744
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640f1ffd3e8b10000889dd8b
😎 Deploy Preview https://deploy-preview-5054--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@@ -180,8 +180,8 @@ export const DoctorCapacity = (props: DoctorCapacityProps) => {
}
}
handleUpdate();
if (btnType == "Save and Exit") handleClose();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 can we make the button types as an enum, something like constants maybe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 6e1e288 into coronasafe:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Doctor Capacity form malfunction
3 participants