Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Script component, load plausible analytics from useConfig instead of env, redact IDs in URLs #5229

Merged
merged 12 commits into from
Apr 7, 2023
Merged

Adds Script component, load plausible analytics from useConfig instead of env, redact IDs in URLs #5229

merged 12 commits into from
Apr 7, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 4, 2023 •
edited
Loading

Proposed Changes

Notes:

  • For it to work locally, rename the script to script.manual.local.js or script.local.manual.js instead of script.manual.js

References:

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team April 4, 2023 05:34
@rithviknishad rithviknishad requested a review from a team as a code owner April 4, 2023 05:34
@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 4:55am

@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7068aec
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642e5060a9411a000861b7ae
😎 Deploy Preview https://deploy-preview-5229--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 4, 2023
@rithviknishad rithviknishad mentioned this pull request Apr 4, 2023
Merged
@rithviknishad rithviknishad changed the title useConfig for plausible analytics loading script instead of env Adds Script component and load plausible analytics script from useConfig instead of env Apr 4, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
5.4% 5.4% Duplication

@rithviknishad rithviknishad removed needs review cypress failed pull request with cypress test failure labels Apr 5, 2023
@rithviknishad rithviknishad marked this pull request as draft April 5, 2023 12:50
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 5, 2023
@rithviknishad rithviknishad changed the title Adds Script component and load plausible analytics script from useConfig instead of env Adds Script component, load plausible analytics from useConfig instead of env, redact IDs in URLs Apr 5, 2023
@rithviknishad rithviknishad marked this pull request as ready for review April 5, 2023 18:49
@rithviknishad rithviknishad added needs review and removed cypress failed pull request with cypress test failure labels Apr 5, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad added needs review and removed cypress failed pull request with cypress test failure labels Apr 6, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 6, 2023
@khavinshankar khavinshankar merged commit ed40094 into develop Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@rithviknishad rithviknishad deleted the plausible-from-use-config branch July 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redact IDs from plausible analytics move plausible analytics envs to config.json
2 participants
@rithviknishad @khavinshankar